linux-kernel - Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 May 2018 07:48:44 -0600
From:   Daniel Drake <drake@...lessm.com>
To:     Chris Chiu <chiu@...lessm.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Benjamin Berg <bberg@...hat.com>,
        Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Upstreaming Team <linux@...lessm.com>,
        Jian-Hong Pan <jian-hong@...lessm.com>
Subject: Re: [PATCH v2] platform/x86: asus-wmi: Add keyboard backlight toggle support

On Tue, May 22, 2018 at 4:11 AM, Chris Chiu <chiu@...lessm.com> wrote:
> On Tue, May 22, 2018 at 5:18 PM, Andy Shevchenko
>> Btw, I mistakenly thought that patch in the queue for-next, while it's
>> not. So, I'm going to drop it now.
>> Feel free to re-submit a new (better) version.
>
> So it's better to handle NOTIFY_KBD_BRTUP, BRTDOWN, BRTTOGGLE
> (c4, c5, c7) in the driver and no need to pass it up to userspace? I'll work
> out a patch for this.

Yes, let's explore this approach before submitting another patch to Andy.

Thanks
Daniel