linux-kernel - Re: [PATCH] kselftest/cgroup: fix variable dereferenced before check warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <351128a3-5bba-8cd2-6d8a-fcaf9c33e2f3@kernel.org>
Date:   Tue, 22 May 2018 09:35:35 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Roman Gushchin <guro@...com>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] kselftest/cgroup: fix variable dereferenced before check
 warning

On 05/22/2018 04:10 AM, Roman Gushchin wrote:
> cg_name(const char *root, const char *name) is always called with
> non-empty root and name arguments, so there is no sense in checking
> it in the function body (after using in strlen()).
> 
> Signed-off-by: Roman Gushchin <guro@...com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: linux-kselftest@...r.kernel.org


Thanks. I will queue this up for 4.18-rc1

-- Shuah