linux-kernel - Re: [PATCH] tc-testing: flush gact actions on test teardown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180522.114930.689064251143958449.davem@davemloft.net>
Date:   Tue, 22 May 2018 11:49:30 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     shuah@...nel.org
Cc:     vladbu@...lanox.com, linux-kselftest@...r.kernel.org,
        lucasb@...atatu.com, jhs@...atatu.com, mrv@...atatu.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tc-testing: flush gact actions on test teardown

From: Shuah Khan <shuah@...nel.org>
Date: Tue, 22 May 2018 09:43:28 -0600

> On 05/18/2018 10:21 AM, Vlad Buslov wrote:
>> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
>> on teardown. Leaking pipe action causes failures in other tests.
>> 
>> Add additional teardown command to also flush gact actions.
>> 
>> Signed-off-by: Vlad Buslov <vladbu@...lanox.com>
>> ---
>>  tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> index 443c9b3..acb24f7 100644
>> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
>> @@ -44,7 +44,8 @@
>>          "matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
>>          "matchCount": "1",
>>          "teardown": [
>> -            "$TC actions flush action mirred"
>> +            "$TC actions flush action mirred",
>> +            "$TC actions flush action gact"
>>          ]
>>      },
>>      {
>> 
> 
> I can get this into 4.18-rc1 unless there is a reason for this to go
> through net tree.

Why wouldn't a networking testing bug fix go through my tree?