[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180522164230.GA11707@rob-hp-laptop>
Date: Tue, 22 May 2018 11:42:30 -0500
From: Rob Herring <robh@...nel.org>
To: Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com>
Cc: Mark Rutland <mark.rutland@....com>,
Haiyue Wang <haiyue.wang@...ux.intel.com>,
Vernon Mauery <vernon.mauery@...ux.intel.com>,
James Feist <james.feist@...ux.intel.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Andrew Jeffery <andrew@...id.au>,
Arnd Bergmann <arnd@...db.de>,
Jason M Biils <jason.m.bills@...ux.intel.com>,
Joel Stanley <joel@....id.au>
Subject: Re: [v4 07/11] dt-bindings: hwmon: Add documents for PECI hwmon
client drivers
On Mon, May 21, 2018 at 12:59:05PM -0700, Jae Hyun Yoo wrote:
> This commit adds dt-bindings documents for PECI hwmon client drivers.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com>
> Reviewed-by: Haiyue Wang <haiyue.wang@...ux.intel.com>
> Reviewed-by: James Feist <james.feist@...ux.intel.com>
> Reviewed-by: Vernon Mauery <vernon.mauery@...ux.intel.com>
> Cc: Andrew Jeffery <andrew@...id.au>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Jason M Biils <jason.m.bills@...ux.intel.com>
> Cc: Joel Stanley <joel@....id.au>
> ---
> .../bindings/hwmon/peci-cputemp.txt | 23 ++++++++++++++++++
> .../bindings/hwmon/peci-dimmtemp.txt | 24 +++++++++++++++++++
> 2 files changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
> new file mode 100644
> index 000000000000..2f59aee12d9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
> @@ -0,0 +1,23 @@
> +Bindings for Intel PECI (Platform Environment Control Interface) cputemp driver.
> +
> +Required properties:
> +- compatible : Should be "intel,peci-cputemp".
> +- reg : Should contain address of a client CPU. Address range of CPU
> + clients is starting from 0x30 based on PECI specification.
> +
> +Example:
> + peci-bus@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + < more properties >
> +
> + peci-cputemp@30 {
> + compatible = "intel,peci-cputemp";
> + reg = <0x30>;
> + };
[...]
> + peci-dimmtemp@30 {
> + compatible = "intel,peci-dimmtemp";
> + reg = <0x30>;
> + };
As I said in the prior version, 2 nodes at the same address is wrong.
Rob
Powered by blists - more mailing lists