[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20180522170433.GX3803@linux.vnet.ibm.com>
Date: Tue, 22 May 2018 10:04:33 -0700
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Roman Pen <roman.penyaev@...fitbricks.com>,
linux-block <linux-block@...r.kernel.org>,
linux-rdma <linux-rdma@...r.kernel.org>,
Jens Axboe <axboe@...nel.dk>,
Christoph Hellwig <hch@...radead.org>,
Sagi Grimberg <sagi@...mberg.me>,
Bart Van Assche <bart.vanassche@...disk.com>,
Or Gerlitz <ogerlitz@...lanox.com>,
Doug Ledford <dledford@...hat.com>,
swapnil.ingle@...fitbricks.com, danil.kipnis@...fitbricks.com,
Jinpu Wang <jinpu.wang@...fitbricks.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 01/26] rculist: introduce list_next_or_null_rr_rcu()
On Tue, May 22, 2018 at 09:38:13AM -0700, Linus Torvalds wrote:
> On Tue, May 22, 2018 at 2:09 AM Roman Penyaev <
> roman.penyaev@...fitbricks.com> wrote:
>
> > Should I resend current patch with more clear comments about how careful
> > caller should be with a leaking pointer?
>
> No. Even if we go your way, there is *one* single user, and that one is
> special and needs to take a lot more care.
>
> Just roll your own version, and make it an inline function like I've asked
> now now many times, and add a shit-ton of explanations of why it's safe to
> use in that *one* situation.
>
> I don't want any crazy and unsafe stuff in the generic header file that
> absolutely *nobody* should ever use.
Completely agreed!
I was perhaps foolishly assuming that they would be making that adjustment
based on earlier emails, but yes, I should have explicitly stated this
requirement in my earlier reply.
Thanx, Paul
Powered by blists - more mailing lists