linux-kernel - Re: [PATCH v7 0/5] AIO add per-command iopriority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da84d129-4dcd-c861-bfc4-62cd425e60e3@kernel.dk>
Date:   Tue, 22 May 2018 11:55:04 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     adam.manzanares@....com, viro@...iv.linux.org.uk,
        linux-fsdevel@...r.kernel.org, bcrl@...ck.org
Cc:     mingo@...nel.org, tglx@...utronix.de, kstewart@...uxfoundation.org,
        peterz@...radead.org, pombredanne@...b.com,
        gregkh@...uxfoundation.org, bigeasy@...utronix.de,
        rgoldwyn@...e.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-aio@...ck.org,
        linux-api@...r.kernel.org, hch@...radread.org, jmoyer@...hat.com
Subject: Re: [PATCH v7 0/5] AIO add per-command iopriority

On 5/22/18 11:52 AM, adam.manzanares@....com wrote:
> From: Adam Manzanares <adam.manzanares@....com>
> 
> This is the per-I/O equivalent of the ioprio_set system call.
> See the following link for performance implications on a SATA HDD:
> https://lkml.org/lkml/2016/12/6/495
> 
> First patch factors ioprio_check_cap function out of ioprio_set system call to
> also be used by the aio ioprio interface.
> 
> Second patch converts kiocb ki_hint field to a u16 to avoid kiocb bloat.
> 
> Third patch passes ioprio hint from aio iocb to kiocb and initializes kiocb
> ioprio value appropriately when it is not explicitly set.
> 
> Fourth patch enables the feature for blkdev.
> 
> Fifth patch enables the feature for iomap direct IO

LGTM, you can add:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

Al, are you picking this series up, or should I?

-- 
Jens Axboe