linux-kernel - Re: [PATCH] x86/speculation: Simplify the CPU bug detection logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1805232149590.1706@nanos.tec.linutronix.de>
Date:   Wed, 23 May 2018 21:50:30 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
cc:     Dominik Brodowski <linux@...inikbrodowski.net>, mingo@...nel.org,
        bp@...e.de, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/speculation: Simplify the CPU bug detection logic

On Wed, 23 May 2018, Konrad Rzeszutek Wilk wrote:
> > @@ -973,16 +965,16 @@ static void __init cpu_set_bug_bits(struct cpuinfo_x86 *c)
> >  	if (cpu_has(c, X86_FEATURE_ARCH_CAPABILITIES))
> >  		rdmsrl(MSR_IA32_ARCH_CAPABILITIES, ia32_cap);
> 
> Would it make sense to move that above 'rdmsrl' and the conditional as well
> to the logic below?

I did that when I was applying the patch ....

Thanks,

	tglx