linux-kernel - Re: [PATCH] fixup! kconfig: refactor ncurses package checks for building mconf and nconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55f33ace-61b0-51f8-647b-7238a5ab32b5@infradead.org>
Date:   Wed, 23 May 2018 14:07:26 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kbuild@...r.kernel.org
Cc:     Sam Ravnborg <sam@...nborg.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fixup! kconfig: refactor ncurses package checks for
 building mconf and nconf

On 05/22/2018 07:11 PM, Masahiro Yamada wrote:
> It is redundant to pass -DNCURSES_WIDECHAR=1 explicitly; when we use
> 'pkg-config --cflags', it takes care of appropriate flags.
> 
> Actually, 'pkg-config --cflags' will add -D_GNU_SOURCE, which will
> define _XOPEN_SOURCE_EXTENDED, and NCURSES_WIDECHAR=1, anyway.
> 
> I added -D_GNU_SOURCE to follow the suggestion of pkg-config
> for cases where pkg-config is not useful.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
> The v3 (https://patchwork.kernel.org/patch/10417413/) was
> reviewed and tested.
> 
> I'd like to squash this into it.

Sure.  Works for me.  Thanks.

> 
> 
>  scripts/kconfig/mconf-cfg.sh | 8 ++++----
>  scripts/kconfig/nconf-cfg.sh | 7 ++++---
>  2 files changed, 8 insertions(+), 7 deletions(-)


-- 
~Randy