[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <15dcff14-ea1b-18c8-4cd1-06586cf6f05b@redhat.com>
Date: Wed, 23 May 2018 15:53:39 -0700
From: Laura Abbott <labbott@...hat.com>
To: Andy Lutomirski <luto@...nel.org>
Cc: Mark Wielaard <mjw@...oraproject.org>,
"H. J. Lu" <hjl.tools@...il.com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
Nick Clifton <nickc@...hat.com>,
Cary Coutant <ccoutant@...il.com>, linux-kbuild@...r.kernel.org
Subject: Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO
On 05/22/2018 05:33 PM, Andy Lutomirski wrote:
> On Tue, May 22, 2018 at 5:19 PM Laura Abbott <labbott@...hat.com> wrote:
>
>
>> The vDSO is linked separately from the kernel and modules. Ensure it picks
>> up the comment section, if available.
>
> Did you end up preferring this to just sticking the kernel version in a
> .comment in the vDSO for some reason?
>
Actually I remember now why this is necessary: there is not a simple way
to encode a string into a linker file as it has to be spit out byte
by byte. The autogeneration was the easiest way to make that happen.
Maybe there's some horrific c preprocessing or other generation that
could happen but I doubt that's any worse than the generated linker
script.
Thanks,
Laura
Powered by blists - more mailing lists