linux-kernel - Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV3o6Dj4xEgVQvJz0tvVLh4Tmvkjp=DdHFui+tNGevU+w@mail.gmail.com>
Date:   Tue, 22 May 2018 17:34:57 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Ivan Babrou <ibobrik@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Paul Turner <pjt@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Mike Galbraith <efault@....de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle

On Mon, May 21, 2018 at 11:35 PM, Ivan Babrou <ibobrik@...il.com> wrote:
>
>
> On Mon, May 21, 2018 at 11:20 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>>
>> +
>> +       TP_printk("path=%s cpu=%d runtime_remaining=%lld",
>> __get_str(cfs_path),
>> +                 __entry->cpu, __entry->runtime_remaining)
>
>
> Can you add "[ns]" as the unit to runtime_remaining? We have it in
> "sched:sched_stat_runtime".

Hmm, although it is indeed ns, this ->runtime_remaining can be negative,
unlike sched_stat_runtime. So I am not sure if I should marked it as "[ns]".