linux-kernel - Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180523090944.GV12217@hirez.programming.kicks-ass.net>
Date:   Wed, 23 May 2018 11:09:44 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Ivan Babrou <ibobrik@...il.com>
Cc:     xiyou.wangcong@...il.com, linux-kernel@...r.kernel.org,
        pjt@...gle.com, efault@....de, tglx@...utronix.de, mingo@...nel.org
Subject: Re: [PATCH 3/3] sched/fair: add tracepoints for cfs throttle

On Mon, May 21, 2018 at 11:35:38PM -0700, Ivan Babrou wrote:
> > +       TP_printk("path=%s cpu=%d runtime_remaining=%lld",
> > __get_str(cfs_path),
> > +                 __entry->cpu, __entry->runtime_remaining)
> >
> 
> Can you add "[ns]" as the unit to runtime_remaining? We have it in
> "sched:sched_stat_runtime".

Yeah, don't worry. I hate tracepoints, I regret the existing ones, no
new ones will happen.