linux-kernel - Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZtE6tD2aM49DNovfEz5DYEjfmh0_=WxaAUY6jLz_tigg@mail.gmail.com>
Date:   Wed, 23 May 2018 11:48:23 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Grigoryev Denis <grigoryev@...twel.ru>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

On Fri, May 4, 2018 at 6:53 PM, Grigoryev Denis <grigoryev@...twel.ru> wrote:

> The driver stores the result of irq_set_type() in the internal variables
> irq_trig_raise and irq_trig_fall, which later are used to determine
> the GPIOs that must be re-configured as input. These variables retain their
> value between gpiolib's  export / unexport, resulting in an incorrect
> state in some cases. The corresponding bits in the variables
> irq_trig_raise and irq_trig_fall should be cleared in irq_shutdown().
>
> Signed-off-by: Denis Grigoryev <grigoryev@...twel.ru>

Patch applied with Andy's ACK.

If there are issues we can just revert it.

Yours,
Linus Walleij