linux-kernel - Re: [PATCH v4 0/4] vfio: ccw: error handling fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180523122129.5f765d24.cohuck@redhat.com>
Date:   Wed, 23 May 2018 12:21:29 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Dong Jia Shi <bjsdjshi@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        kvm@...r.kernel.org, borntraeger@...ibm.com, pasic@...ux.ibm.com,
        pmorel@...ux.ibm.com
Subject: Re: [PATCH v4 0/4] vfio: ccw: error handling fixes and improvements

On Wed, 23 May 2018 04:56:41 +0200
Dong Jia Shi <bjsdjshi@...ux.ibm.com> wrote:

> Dear Reviewers,
> 
> Here is a new version for this patch series.
> 
> We didn't get agreement on patch #4 (#5 in v2) in the former cycle though,
> I made it based on my understanding. We can continue discussing on it.

I'll probably go ahead and queue 1-3 (would not mind r-bs, though) in
any case.

I hope we can queue the tracing patch as well, as any tracing beats no
tracing :)

> 
> Changelog:
> v3->v4:
>  - Change mail address from @linux.vnet.ibm.com to @linux.ibm.com
> 
> v2->v3:
>  - #2. Reworded comment message.
>  - #4. Trace failure only, trace all error path, and a common knob for all
>        failure paths.
> 
> v1->v2:
>  - #1. Reworded commit message and comment, plus some typo fixes.
>  - #2. New patch.
>  - #3. Added the missing suggested-by Pierre.
>        Fixed typos.
>        Added sanity check on pa->pa_iova_pfn and updated comments accordingly.
>  - #4. Removed unused idaw_nr.
>  - #5. Replaced leading white spaces with TABs.
>        Traced the function in anycase.
> 
> Dong Jia Shi (3):
>   vfio: ccw: shorten kernel doc description for pfn_array_pin()
>   vfio: ccw: refactor and improve pfn_array_alloc_pin()
>   vfio: ccw: set ccw->cda to NULL defensively
> 
> Halil Pasic (1):
>   vfio: ccw: add traceponits for interesting error paths
> 
>  drivers/s390/cio/Makefile         |   1 +
>  drivers/s390/cio/vfio_ccw_cp.c    | 121 +++++++++++++++++++-------------------
>  drivers/s390/cio/vfio_ccw_fsm.c   |  17 +++++-
>  drivers/s390/cio/vfio_ccw_trace.h |  54 +++++++++++++++++
>  4 files changed, 130 insertions(+), 63 deletions(-)
>  create mode 100644 drivers/s390/cio/vfio_ccw_trace.h
>