linux-kernel - Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <B82BB5F4-E197-4915-A543-C5FF9A5A41F1@holtmann.org>
Date:   Wed, 23 May 2018 14:31:30 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Sean Wang <sean.wang@...iatek.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        BlueZ development <linux-bluetooth@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 4/7] Bluetooth: Add new quirk for non-persistent setup
 settings

Hi Sean,

>> 
>> [ ... ]
>> 
>>>> -	if (hci_dev_test_flag(hdev, HCI_SETUP)) {
>>>> +	if (hci_dev_test_flag(hdev, HCI_SETUP) ||
>>>> +	    test_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks)) {
>>>> 		hci_sock_dev_event(hdev, HCI_DEV_SETUP);
>>> 
>>> I am not 100% sure that we want to send the HCI_DEV_SETUP event also multiple times. That is a userspace change that I would need to think about. We need to check create_monitor_event() and see what the btmon trace for this looks like. Can you send me a btmon -w trace.log when this change is active.
>>> 
>>> Regards
>>> 
>>> Marcel
>>> 
>> 
>> Sure, I'll send you the trace.log with the change is active.
>> 
>> 	Sean
>> 
> 
> 
> Attached trace.log was captured when I inputted commands power on and
> then off in bluetoothctl.

the trace.log is somehow mangled. Something is not fully correct. Can you read it with btmon -r trace.log?

Regards

Marcel