linux-kernel - Re: [PATCH v2] powerpc/xmon: Also setup debugger hooks when single-stepping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <877enuxmfa.fsf@vajain21.in.ibm.com>
Date:   Wed, 23 May 2018 23:51:45 +0530
From:   Vaibhav Jain <vaibhav@...ux.vnet.ibm.com>
To:     Michal Suchanek <msuchanek@...e.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Balbir Singh <bsingharora@...il.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Breno Leitao <leitao@...ian.org>,
        "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>,
        Michal Suchanek <msuchanek@...e.de>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] powerpc/xmon: Also setup debugger hooks when single-stepping

Michal Suchanek <msuchanek@...e.de> writes:

> When single-stepping kernel code from xmon without a debug hook enabled
> the kernel crashes. This can happen when kernel starts with xmon on
> crash disabled but xmon is entered using sysrq.
>
> Call force_enable_xmon when single-stepping in xmon to install the xmon
> debug hooks.
>
> Fixes: e1368d0c9edb ("powerpc/xmon: Setup debugger hooks when first
> break-point is set")
>
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> ---
LGTM,

Reviewed-by: Vaibhav Jain <vaibhav@...ux.ibm.com>

-- 
Vaibhav Jain <vaibhav@...ux.ibm.com>
Linux Technology Center, IBM India Pvt. Ltd.