linux-kernel - Re: [PATCH 4.14 110/165] scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <fdd36949-3a0c-0b7d-1946-34fd253569c5@linux.ibm.com>
Date:   Thu, 24 May 2018 14:19:29 +0200
From:   Steffen Maier <maier@...ux.ibm.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Bart Van Assche <bart.vanassche@....com>
Cc:     stable@...r.kernel.org, Doug Gilbert <dgilbert@...erlog.com>,
        Hannes Reinecke <hare@...e.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.14 110/165] scsi: core: return BLK_STS_OK for DID_OK in
 __scsi_error_from_host_byte()

Hopefully I haven't missed it in the stable queue, but do we need the 
following on top (effectively not applying e39a97353e53)?:

commit cbe095e2b584623b882ebaf6c18e0b9077baa3f7
Author: Bart Van Assche <bart.vanassche@....com>
Date:   Thu Apr 5 10:32:59 2018 -0700

     Revert "scsi: core: return BLK_STS_OK for DID_OK in 
__scsi_error_from_host_byte()"

     The description of commit e39a97353e53 is wrong: it mentions that 
commit
     2a842acab109 introduced a bug in __scsi_error_from_host_byte() 
although that
     commit did not change the behavior of that function.  Additionally, 
commit
     e39a97353e53 introduced a bug: it causes commands that fail with
     hostbyte=DID_OK and driverbyte=DRIVER_SENSE to be completed with
     BLK_STS_OK. Hence revert that commit.

     Fixes: e39a97353e53 ("scsi: core: return BLK_STS_OK for DID_OK in 
__scsi_error_from_host_byte()")
     Reported-by: Damien Le Moal <damien.lemoal@....com>
     Signed-off-by: Bart Van Assche <bart.vanassche@....com>
     Cc: Hannes Reinecke <hare@...e.com>
     Cc: Douglas Gilbert <dgilbert@...erlog.com>
     Cc: Damien Le Moal <damien.lemoal@....com>
     Cc: Christoph Hellwig <hch@....de>
     Cc: Lee Duncan <lduncan@...e.com>
     Cc: stable@...r.kernel.org
     Reviewed-by: Christoph Hellwig <hch@....de>
     Reviewed-by: Hannes Reinecke <hare@...e.com>
     Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>


On 05/24/2018 11:38 AM, Greg Kroah-Hartman wrote:
> 4.14-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Hannes Reinecke <hare@...e.de>
> 
> [ Upstream commit e39a97353e5378eb46bf01679799c5704d397f32 ]
> 
> When converting __scsi_error_from_host_byte() to BLK_STS error codes the
> case DID_OK was forgotten, resulting in it always returning an error.
> 
> Fixes: 2a842acab109 ("block: introduce new block status code type")
> Cc: Doug Gilbert <dgilbert@...erlog.com>
> Signed-off-by: Hannes Reinecke <hare@...e.com>
> Reviewed-by: Douglas Gilbert <dgilbert@...erlog.com>
> Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>   drivers/scsi/scsi_lib.c |    2 ++
>   1 file changed, 2 insertions(+)
> 
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -720,6 +720,8 @@ static blk_status_t __scsi_error_from_ho
>   		int result)
>   {
>   	switch (host_byte(result)) {
> +	case DID_OK:
> +		return BLK_STS_OK;
>   	case DID_TRANSPORT_FAILFAST:
>   		return BLK_STS_TRANSPORT;
>   	case DID_TARGET_FAILURE:
> 
> 


-- 
Mit freundlichen Gruessen / Kind regards
Steffen Maier

Linux on IBM Z Development

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294