linux-kernel - Re: [PATCH v2] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 24 May 2018 09:01:54 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Guenter Roeck <linux@...ck-us.net>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] pinctrl: cherryview: limit Strago DMI workarounds to
 version 1.0

Hi Linus,

On Thu, May 24, 2018 at 10:19:55AM +0200, Linus Walleij wrote:
> On Tue, May 22, 2018 at 10:47 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
> 
> > As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> > virtual interrupt numbers for keyboard/touchpad/touchscreen controllers
> > in ACPI tables, they will also update BOARD version number from 1.0
> > to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ
> > numbers on Strago boards to those that still carry older BIOSes.
> >
> > Note that ideally not BOARD but BIOS version should have been updated.
> > However the BIOS version used by Chrome devices has format of
> > Google_BUILD.BRANCH.PATCH which is not well suited for DMI matching as
> > we do not have "less than" match mode for DMI data.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > ---
> >
> > v1->v2:
> >
> > - switch from matching on DMI_BIOS_VERSION to DMI_BOARD_VERSION
> 
> Patch applied for fixes.
> 
> Should this also be tagged for stable?

No, I do not think so. The workaround being active does not cause any
issues on boxes with updated firmware, so there is no point in trying to
get the patch to older kernels. It is going forward that we want the
"proper" behavior, when possible.

Also, I am not quite sure when the new firmware version will get
qualified for release.

Thanks.

-- 
Dmitry