linux-kernel - Re: [REVIEW][PATCH 4/6] fs: Allow superblock owner to access do_remount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180524172821.GA27641@mailbox.org>
Date:   Thu, 24 May 2018 19:28:21 +0200
From:   Christian Brauner <christian@...uner.io>
To:     "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Linux Containers <containers@...ts.linux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Seth Forshee <seth.forshee@...onical.com>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [REVIEW][PATCH 4/6] fs: Allow superblock owner to access
 do_remount_sb()

On Thu, May 24, 2018 at 11:45:06AM -0500, Eric W. Biederman wrote:
> Christian Brauner <christian@...uner.io> writes:
> 
> > On Wed, May 23, 2018 at 06:25:36PM -0500, Eric W. Biederman wrote:
> >> Superblock level remounts are currently restricted to global
> >> CAP_SYS_ADMIN, as is the path for changing the root mount to
> >> read only on umount. Loosen both of these permission checks to
> >> also allow CAP_SYS_ADMIN in any namespace which is privileged
> >> towards the userns which originally mounted the filesystem.
> >
> > Acked-by: Christian Brauner <christian@...uner.io>
> >
> >> 
> >> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>
> >> Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com>
> >> Acked-by: Serge Hallyn <serge.hallyn@...onical.com>
> >
> > Note, I just talked to Serge. This should be Acked-by: Serge Hallyn <serge@...lyn.com>
> 
> Now you know how long these patches have been sitting waiting to get
> merged.

Indeed. :)

Christian