linux-kernel - [PATCH 0/2] Provide defines for 104-QUAD-8 magic numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 May 2018 16:37:35 -0400
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     jic23@...nel.org
Cc:     knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        William Breathitt Gray <vilhelm.gray@...il.com>
Subject: [PATCH 0/2] Provide defines for 104-QUAD-8 magic numbers

Magic numbers can be difficult to understand, and at times hide bugs
that would otherwise be obvious to readers of the source code.

The first patch in this patchset provides a fix for an improperly
selected magic number (an off-by-one error). The second patch adds
defines to remove these magic numbers and thus help make the driver
source code easier to read and debug.

The discovery of the error fixed by the first patch is thanks to these
defines: the improper magic number stuck out like a sore thumb next
to the expected define symbol. So I should have used these defines from
the start.

William Breathitt Gray (2):
  iio: 104-quad-8: Fix off-by-one error in register selection
  iio: 104-quad-8: Provide defines for magic numbers

 drivers/iio/counter/104-quad-8.c | 86 ++++++++++++++++++++++----------
 1 file changed, 60 insertions(+), 26 deletions(-)

-- 
2.17.0