linux-kernel - Re: [PATCH] tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9152600.1bIX9UMnel@aspire.rjw.lan>
Date:   Thu, 24 May 2018 11:34:38 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Doug Smythies <doug.smythies@...il.com>
Cc:     srinivas.pandruvada@...ux.intel.com, dsmythies@...us.net,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel_pstate_tracer: Add optional setting of trace buffer memory allocation

On Sunday, May 13, 2018 10:43:02 AM CEST Rafael J. Wysocki wrote:
> On Friday, May 4, 2018 3:46:22 PM CEST Doug Smythies wrote:
> > Allow the user to override the default trace buffer memory allocation
> > by adding a command line option to override the default.
> > 
> > The patch also:
> > 
> > Adds a SIGINT (i.e. CTRL C exit) handler,
> > so that things can be cleaned up before exit.
> > 
> > Moves the postion of some other cleanup from after to
> > before the potential "No valid data to plot" exit.
> > 
> > Replaces all quit() calls with sys.exit, because
> > quit() is not supposed to be used in scripts.
> > 
> > Signed-off-by: Doug Smythies <dsmythies@...us.net>
> 
> Srinivas, any comments here?

No concerns, so applied.  Thanks!