linux-kernel - Re: [PATCH v13 1/2] cpufreq: Add Kryo CPU scaling driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180525035412.3jjocp7ccmv5u2il@vireshk-i7>
Date:   Fri, 25 May 2018 09:24:12 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Ilia Lin <ilialin@...eaurora.org>
Cc:     vireshk@...nel.org, nm@...com, sboyd@...nel.org, robh@...nel.org,
        mark.rutland@....com, rjw@...ysocki.net, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 1/2] cpufreq: Add Kryo CPU scaling driver

On 24-05-18, 18:03, Ilia Lin wrote:
> +static int __init qcom_cpufreq_kryo_init(void)
> +{
> +	struct device_node *np;
> +	struct device *cpu_dev;
> +	int ret;
> +
> +	cpu_dev = get_cpu_device(0);
> +	if (NULL == cpu_dev)
> +		ret = -ENODEV;
> +
> +	np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
> +	if (IS_ERR(np))
> +		return PTR_ERR(np);
> +
> +	ret = of_device_is_compatible(np, "operating-points-v2-kryo-cpu");
> +	of_node_put(np);
> +	if (!ret)
> +		return -ENOENT;
> +

I hate the fact that it is taking so long to get done with this. But can't you
just check machine compatibility instead of this complicated setup to check OPP
node ? Like:

        if (!of_device_is_compatible("qcom,apq8096") &&
            !of_device_is_compatible("qcom,msm8996"))
                return;

And please see if you can add an entry in MAINTAINERS and add your working email
id there.

-- 
viresh