linux-kernel - Re: [PATCH] staging: comedi: comedidev.h: Fix SPDX-License-Identifier tag style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a53f7415-2638-b761-b880-e99ef8e6d4c5@mev.co.uk>
Date:   Fri, 25 May 2018 12:08:54 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Nishad Kamdar <nishadkamdar@...il.com>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: comedidev.h: Fix SPDX-License-Identifier
 tag style

On 24/05/18 18:44, Nishad Kamdar wrote:
> Replace // SPDX-License-Identifier: GPL-2.0+ by
> /* SPDX-License-Identifier: GPL-2.0+ */ as per licensing rule
> for C header files. Issue found by checkpatch. Part of
> Eudyptula Challenge.
> 
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> ---
>   drivers/staging/comedi/comedidev.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index f3474a4ba69e..c54ac94d89d2 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0+
> +/* SPDX-License-Identifier: GPL-2.0+ */
>   /*
>    * comedidev.h
>    * header file for kernel-only structures, variables, and constants
> 

That looks fine thanks.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott <abbotti@....co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-