linux-kernel - Re: [PATCH 1/2] ARM: stm32: Don't select DMA unconditionally on STM32MP157C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180525222649.adxut6t7w53ugykx@localhost>
Date:   Fri, 25 May 2018 15:26:49 -0700
From:   Olof Johansson <olof@...om.net>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     arm@...nel.org, Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Ludovic Barre <ludovic.barre@...com>,
        Pierre-Yves MORDRET <pierre-yves.mordret@...com>,
        Patrice Chotard <patrice.chotard@...com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: stm32: Don't select DMA unconditionally on
 STM32MP157C

On Fri, May 25, 2018 at 06:09:13PM +0200, Arnd Bergmann wrote:
> The patch that enabled these had no useful changelog that explains
> why it is done, and it causes a build warning:
> 
> WARNING: unmet direct dependencies detected for STM32_DMA
>   Depends on [n]: DMADEVICES [=n] && (ARCH_STM32 [=y] || COMPILE_TEST [=y])
>   Selected by [y]:
>   - MACH_STM32MP157 [=y] && ARCH_STM32 [=y] && ARCH_MULTI_V7 [=y]
> 
> Generally, platforms should not select arbitrary drivers, so let's
> just revert that change.
> 
> Fixes: de6037fa207f ("ARM: stm32: Select DMA, DMAMUX and MDMA support on STM32MP157C")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to next/soc now.


-Olof