linux-kernel - [tip:x86/microcode] x86/microcode: Make the late update update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-ff987fcf011d20c53b3a613edf6e2055ea48e26e@git.kernel.org>
Date:   Sun, 27 May 2018 12:55:00 -0700
From:   tip-bot for Scott Wood <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     williams@...hat.com, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, bp@...e.de, ashok.raj@...el.com,
        mingo@...nel.org, x86@...nel.org, pezhang@...hat.com,
        swood@...hat.com, hpa@...or.com
Subject: [tip:x86/microcode] x86/microcode: Make the late update update_lock
 a raw lock for RT

Commit-ID:  ff987fcf011d20c53b3a613edf6e2055ea48e26e
Gitweb:     https://git.kernel.org/tip/ff987fcf011d20c53b3a613edf6e2055ea48e26e
Author:     Scott Wood <swood@...hat.com>
AuthorDate: Thu, 24 May 2018 10:44:20 -0500
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sun, 27 May 2018 21:50:09 +0200

x86/microcode: Make the late update update_lock a raw lock for RT

__reload_late() is called from stop_machine context and thus cannot
acquire a non-raw spinlock on PREEMPT_RT.

Signed-off-by: Scott Wood <swood@...hat.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Acked-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Ashok Raj <ashok.raj@...el.com>
Cc: Clark Williams <williams@...hat.com>
Cc: Pei Zhang <pezhang@...hat.com>
Cc: x86-ml <x86@...nel.org>
Link: http://lkml.kernel.org/r/20180524154420.24455-1-swood@redhat.com
---
 arch/x86/kernel/cpu/microcode/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index 77e201301528..08286269fd24 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -70,7 +70,7 @@ static DEFINE_MUTEX(microcode_mutex);
 /*
  * Serialize late loading so that CPUs get updated one-by-one.
  */
-static DEFINE_SPINLOCK(update_lock);
+static DEFINE_RAW_SPINLOCK(update_lock);
 
 struct ucode_cpu_info		ucode_cpu_info[NR_CPUS];
 
@@ -560,9 +560,9 @@ static int __reload_late(void *info)
 	if (__wait_for_cpus(&late_cpus_in, NSEC_PER_SEC))
 		return -1;
 
-	spin_lock(&update_lock);
+	raw_spin_lock(&update_lock);
 	apply_microcode_local(&err);
-	spin_unlock(&update_lock);
+	raw_spin_unlock(&update_lock);
 
 	/* siblings return UCODE_OK because their engine got updated already */
 	if (err > UCODE_NFOUND) {