linux-kernel - Re: [PATCH] iio: adc: sun4i-gpadc: select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180527103520.134fb6f8@archlinux>
Date:   Sun, 27 May 2018 10:35:20 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Quentin Schulz <quentin.schulz@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Mark Brown <broonie@...nel.org>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: sun4i-gpadc: select REGMAP_IRQ

On Fri, 25 May 2018 17:34:23 +0200
Arnd Bergmann <arnd@...db.de> wrote:

> We can't call regmap_irq_get_virq() unless the regmap-irq support
> is enabled:
> 
> drivers/iio/adc/sun4i-gpadc-iio.o: In function `sun4i_irq_init':
> sun4i-gpadc-iio.c:(.text+0x59c): undefined reference to `regmap_irq_get_virq'
> 
> I came across this in a randconfig build now, but I guess this is
> a much older problem that I simply never hit before because regmap_irq
> is usually enabled by one of the other drivers that need it.
> 
> Fixes: d1caa9905538 ("iio: adc: add support for Allwinner SoCs ADC")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to the togreg branch of iio.git.  I might move it to the fixes
branch if the merge window opens shortly so as to get it upstream
faster. Pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 9da79070357c..13922b595503 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -717,6 +717,7 @@ config SUN4I_GPADC
>  	depends on IIO
>  	depends on MFD_SUN4I_GPADC || MACH_SUN8I
>  	depends on THERMAL || !THERMAL_OF
> +	select REGMAP_IRQ
>  	help
>  	  Say yes here to build support for Allwinner (A10, A13 and A31) SoCs
>  	  GPADC. This ADC provides 4 channels which can be used as an ADC or as