linux-kernel - Re: [PATCH 3/5] scsi: ufs: Add Kconfig for UFS HC driver crypto support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <394042f2-2231-37c9-f875-979415dbdf58@infradead.org>
Date:   Mon, 28 May 2018 08:48:47 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ladvine D Almeida <Ladvine.DAlmeida@...opsys.com>,
        Vinayak Holikatti "<vinholikatti@...il.com>;" "\"James" "E.J."
         "Bottomley\"" "<jejb@...ux.vnet.ibm.com>;" "\"Martin" "K."
         "Petersen\"" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org,
        "linux-scsi@...r.kernel.org;" Manjunath M Bettegowda
         "<manjumb@...opsys.com>;" Prabu Thangamuthu
         "<prabut@...opsys.com>;" Tejas Joglekar
         "<joglekar@...opsys.com>;" Joao Pinto <Joao.Pinto@...opsys.com>
Subject: Re: [PATCH 3/5] scsi: ufs: Add Kconfig for UFS HC driver crypto
 support

On 05/28/2018 06:29 AM, Ladvine D Almeida wrote:
> 
> This patch adds the Kconfig for enabling crypto support for
> UFS Host Controller driver. It also adds Makefile changes
> for building crypto support based on crypto Kconfig selection.
> 
> Signed-off-by: Ladvine D Almeida <ladvine@...opsys.com>
> ---
>  drivers/scsi/ufs/Kconfig  | 15 +++++++++++++++
>  drivers/scsi/ufs/Makefile |  6 +++++-
>  2 files changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
> index e27b4d4..0134672 100644
> --- a/drivers/scsi/ufs/Kconfig
> +++ b/drivers/scsi/ufs/Kconfig
> @@ -50,6 +50,21 @@ config SCSI_UFSHCD
>  	  However, do not compile this as a module if your root file system
>  	  (the one containing the directory /) is located on a UFS device.
>  
> +config SCSI_UFSHCD_INLINE_ENCRYPTION
> +	bool "Universal Flash Storage Controller Driver crypto support"
> +	depends on SCSI_UFSHCD
> +	default n
> +	select BLK_DEV_INLINE_ENCRYPTION if SCSI_UFSHCD_INLINE_ENCRYPTION
> +	help
> +	This enables the Inline Encryption feature of the UFS Host
> +	Controller driver. Once the capability is detected in hardware,
> +	it will be made available for the user through Linux Kernel
> +	Cryptography Framework(LKCF).

The help text above should be indented (as below), with one tab + 2 spaces.

> +
> +	  If you have a controller with this capability, say Y.
> +
> +	  If unsure, say N.
> +
>  config SCSI_UFSHCD_PCI
>  	tristate "PCI bus based UFS Controller support"
>  	depends on SCSI_UFSHCD && PCI


-- 
~Randy