linux-kernel - Re: [patch v22 1/4] drivers: jtag: Add JTAG core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201805300309.xm57deLw%fengguang.wu@intel.com>
Date:   Wed, 30 May 2018 04:08:53 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Oleksandr Shamray <oleksandrs@...lanox.com>
Cc:     kbuild-all@...org, gregkh@...uxfoundation.org, arnd@...db.de,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org,
        joel@....id.au, jiri@...nulli.us, tklauser@...tanz.ch,
        linux-serial@...r.kernel.org, vadimp@...lanox.com,
        system-sw-low-level@...lanox.com, robh+dt@...nel.org,
        openocd-devel-owner@...ts.sourceforge.net,
        linux-api@...r.kernel.org, davem@...emloft.net, mchehab@...nel.org,
        Oleksandr Shamray <oleksandrs@...lanox.com>
Subject: Re: [patch v22 1/4] drivers: jtag: Add JTAG core driver

Hi Oleksandr,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc7 next-20180529]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Oleksandr-Shamray/JTAG-driver-introduction/20180529-195609
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sh 

All errors (new ones prefixed by >>):

>> drivers/jtag/jtag.c:288:13: error: static declaration of 'devm_jtag_unregister' follows non-static declaration
    static void devm_jtag_unregister(struct device *dev, void *res)
                ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/jtag/jtag.c:9:0:
   include/linux/jtag.h:38:6: note: previous declaration of 'devm_jtag_unregister' was here
    void devm_jtag_unregister(struct device *dev, void *res);
         ^~~~~~~~~~~~~~~~~~~~

vim +/devm_jtag_unregister +288 drivers/jtag/jtag.c

   287	
 > 288	static void devm_jtag_unregister(struct device *dev, void *res)
   289	{
   290		jtag_unregister(*(struct jtag **)res);
   291	}
   292	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (47739 bytes)