linux-kernel - Re: [PATCH 2/8] ima: Use audit_log_format() rather than audit_log_string()

Open Source and information security mailing list archives

Message-ID: <CAHC9VhTy+7Cdb65bZBp9w1_TbOtdcKk_Ejv53ud+ag2WFqaQ5A@mail.gmail.com>
Date:   Tue, 29 May 2018 16:31:09 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:     zohar@...ux.vnet.ibm.com, sgrubb@...hat.com,
        linux-integrity@...r.kernel.org, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] ima: Use audit_log_format() rather than audit_log_string()

On Thu, May 24, 2018 at 4:10 PM, Stefan Berger
<stefanb@...ux.vnet.ibm.com> wrote:
> Remove the usage of audit_log_string() and replace it with
> audit_log_format().
>
> Signed-off-by: Stefan Berger <stefanb@...ux.vnet.ibm.com>
> Suggested-by: Steve Grubb <sgrubb@...hat.com>
> Reviewed-by: Mimi Zohar <zohar@...ux.vnet.ibm.com>
> ---
>  security/integrity/ima/ima_policy.c  | 3 +--
>  security/integrity/integrity_audit.c | 6 +-----
>  2 files changed, 2 insertions(+), 7 deletions(-)

Acked-by: Paul Moore <paul@...l-moore.com>

> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> index a823f11a3e6b..7297450b813c 100644
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -615,8 +615,7 @@ static void ima_log_string_op(struct audit_buffer *ab, char *key, char *value,
>                 audit_log_format(ab, "%s<", key);
>         else
>                 audit_log_format(ab, "%s=", key);
> -       audit_log_string(ab, value);
> -       audit_log_format(ab, " ");
> +       audit_log_format(ab, "%s ", value);
>  }
>  static void ima_log_string(struct audit_buffer *ab, char *key, char *value)
>  {
> diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c
> index 90987d15b6fe..db30763d5525 100644
> --- a/security/integrity/integrity_audit.c
> +++ b/security/integrity/integrity_audit.c
> @@ -45,11 +45,7 @@ void integrity_audit_msg(int audit_msgno, struct inode *inode,
>                          from_kuid(&init_user_ns, audit_get_loginuid(current)),
>                          audit_get_sessionid(current));
>         audit_log_task_context(ab);
> -       audit_log_format(ab, " op=");
> -       audit_log_string(ab, op);
> -       audit_log_format(ab, " cause=");
> -       audit_log_string(ab, cause);
> -       audit_log_format(ab, " comm=");
> +       audit_log_format(ab, " op=%s cause=%s comm=", op, cause);
>         audit_log_untrustedstring(ab, get_task_comm(name, current));
>         if (fname) {
>                 audit_log_format(ab, " name=");
> --
> 2.13.6
>
> --
> Linux-audit mailing list
> Linux-audit@...hat.com
> https://www.redhat.com/mailman/listinfo/linux-audit


-- 
paul moore
www.paul-moore.com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives