linux-kernel - Re: v4.17-rc1: regressions on N900, N950

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180529204517.GA6765@amd>
Date:   Tue, 29 May 2018 22:45:17 +0200
From:   Pavel Machek <pavel@....cz>
To:     Tony Lindgren <tony@...mide.com>,
        laurent.pinchart@...asonboard.com,
        sebastian.reichel@...labora.co.uk
Cc:     Aaro Koskinen <aaro.koskinen@....fi>,
        Pali Rohár <pali.rohar@...il.com>,
        sre@...nel.org, kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-omap@...r.kernel.org, khilman@...nel.org,
        ivo.g.dimitrov.75@...il.com, patrikbachan@...il.com,
        serge@...lyn.com, abcloriens@...il.com, clayton@...ftyguy.net,
        martijn@...xit.nl, sakari.ailus@...ux.intel.com,
        Filip Matijević <filip.matijevic.pz@...il.com>,
        Thorsten Leemhuis <regressions@...mhuis.info>
Subject: Re: v4.17-rc1: regressions on N900, N950

Hi!

> > > still results in working touchscreen, removing any of the three fields
> > > breaks it again.
> > 
> > I bisected one regression down, see "omapdrm regression in v4.17-rc series"
> > not sure if it covers all the issues being discussed here though.
> 
> Reverting 24aac6011f70 fixes screen on n900 in v4.17-rc for me. (But
> strange dependency on tsc2005@0 is still there).

Laurent, your patch looks pretty obvious, but unfortunately breaks
display on Nokia N900.

The patch is pretty big as is, perhaps you have version split to sdi
=> *sdi and then static => dynamic allocation?

Thanks,
								Pavel

commit 24aac6011f704d69b5f34514923413f85669f282
Author: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Date:   Tue Feb 13 14:00:47 2018 +0200

    drm: omapdrm: sdi: Allocate the sdi private data structure
    dynamically

    The sdi private data structure is currently stored as a global
        variable. While no platform with multiple SDI encoders
        currently exists
	    nor is planned, this doesn't comply with the kernel device
        model and
	    should thus be fixed.
    


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)