linux-kernel - Re: [PATCH] platform: chrome: Add input dependency for tablet switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180529055405.GA26811@decatoncale.mtv.corp.google.com>
Date:   Mon, 28 May 2018 22:54:05 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Benson Leung <bleung@...omium.org>,
        Olof Johansson <olof@...om.net>,
        Gwendal Grignou <gwendal@...omium.org>,
        Thierry Escande <thierry.escande@...labora.com>,
        Lee Jones <lee.jones@...aro.org>,
        Shawn Nematbakhsh <shawnn@...omium.org>,
        linux-kernel@...r.kernel.org, bleung@...gle.com
Subject: Re: [PATCH] platform: chrome: Add input dependency for tablet switch
 driver

Hi Arnd,

On Mon, May 28, 2018 at 05:58:46PM +0200, Arnd Bergmann wrote:
> Without CONFIG_INPUT, or with a modular input layer and built-in
> tablet driver, we get a link error:
> 
> ERROR: "input_event" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!
> ERROR: "input_register_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!
> ERROR: "input_set_capability" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!
> ERROR: "devm_input_allocate_device" [drivers/platform/chrome/chromeos_tbmc.ko] undefined!
> 
> This adds the corresponding Kconfig dependency
> 
> Fixes: b418f74170d7 ("platform: chrome: Add Tablet Switch ACPI driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for the catch! Applied for 4.18.

Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)