linux-kernel - Re: [PATCH] riscv: pass machine size to sparse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180529061127.GA20005@infradead.org>
Date:   Mon, 28 May 2018 23:11:27 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     Palmer Dabbelt <palmer@...ive.com>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Albert Ou <albert@...ive.com>, yamada.masahiro@...ionext.com,
        michal.lkml@...kovi.net
Subject: Re: [PATCH] riscv: pass machine size to sparse

On Mon, May 28, 2018 at 06:35:05PM +0200, Luc Van Oostenryck wrote:
> By default, sparse assumes a 64bit machine when compiled on x86-64
> and 32bit when compiled on anything else.
> 
> This can of course create all sort of problems when this doesn't
> correspond to the target's machine size, like issuing false
> warnings like: 'shift too big (32) for type unsigned long' or
> is 64bit while sparse was compiled on a 32bit machine, or worse,
> to not emit legitimate warnings.
> 
> Fix this by passing the appropriate -m32/-m64 flag to sparse.

Can we please move this to the common Kbuild code using the
CONFIG_64BIT syombol?  This really should not need boiler plate in
every architecture.