linux-kernel - Re: [alsa-devel] [PATCH] ALSA: xen: ensure nul-terminated device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4lirasc5.wl-tiwai@suse.de>
Date:   Tue, 29 May 2018 08:28:26 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Oleksandr Andrushchenko" <andr2000@...il.com>
Cc:     "Arnd Bergmann" <arnd@...db.de>,
        "Oleksandr Andrushchenko" <oleksandr_andrushchenko@...m.com>,
        "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ALSA: xen: ensure nul-terminated device name

On Tue, 29 May 2018 07:48:51 +0200,
Oleksandr Andrushchenko wrote:
> 
> On 05/28/2018 06:59 PM, Arnd Bergmann wrote:
> > gcc-8 warns that pcm_instance->name is not necessarily terminated correctly
> > if the input is more than 80 characters long or lacks a termination byte
> > itself:
> >
> > In function 'strncpy',
> >      inlined from 'cfg_device' at sound/xen/xen_snd_front_cfg.c:399:3,
> >      inlined from 'xen_snd_front_cfg_card' at sound/xen/xen_snd_front_cfg.c:509:9:
> > include/linux/string.h:254:9: error: '__builtin_strncpy' specified bound 80 equals destination size [-Werror=stringop-truncation]
> >    return __builtin_strncpy(p, q, size);
> >
> > Using strlcpy() instead of strncpy() makes this a bit safer.
> >
> > Fixes: fd3b36045c2c ("ALSA: xen-front: Read sound driver configuration from Xen store")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >   sound/xen/xen_snd_front_cfg.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/xen/xen_snd_front_cfg.c b/sound/xen/xen_snd_front_cfg.c
> > index 38c7e1eefbb9..684b5f1d51ac 100644
> > --- a/sound/xen/xen_snd_front_cfg.c
> > +++ b/sound/xen/xen_snd_front_cfg.c
> > @@ -396,7 +396,7 @@ static int cfg_device(struct xen_snd_front_info *front_info,
> >     	str = xenbus_read(XBT_NIL, device_path,
> > XENSND_FIELD_DEVICE_NAME, NULL);
> >   	if (!IS_ERR(str)) {
> > -		strncpy(pcm_instance->name, str, sizeof(pcm_instance->name));
> > +		strlcpy(pcm_instance->name, str, sizeof(pcm_instance->name));
> >   		kfree(str);
> >   	}
> >   
> Thank you for your patch,
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>

Applied now.  Thanks.


Takashi