linux-kernel - Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180529071119.GB32615@lst.de>
Date:   Tue, 29 May 2018 09:11:19 +0200
From:   Christoph Hellwig <hch@....de>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Christoph Hellwig <hch@....de>,
        Guenter Roeck <linux@...ck-us.net>,
        Joshua Thompson <funaho@...ai.org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh
        SONIC based ethernet

On Tue, May 29, 2018 at 03:38:23PM +1000, Finn Thain wrote:
> On Tue, 29 May 2018, Michael Schmitz wrote:
> 
> > > 
> > > Since an arch gets to apply limits in the dma ops it implements, why 
> > > would arch code also have to set a limit in the form of default 
> > > platform device masks? Powerpc seems to be the only arch that does 
> > > this.
> > 
> > One of Christoph's recent patches removed most of arches' dma ops, 
> > replacing them by one generic implementation instead. m68k was one of 
> > the affected arches. I concede his patch series is experimental still 
> > and not in mainline, but may be included at some time.
> 
> I found some patches here,
> http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/generic-dma-noncoherent.2
> 
> Looks like m68k_dma_alloc() gets renamed arch_dma_alloc() and the generic 
> ops don't use the dma masks.

This is for the 'coherent' allocations, and literatelly nothing changes
for those yet.

But for the mapping path this switches m68k to use the dma-direct
path, wrapped by dma-noncoherent.  And these do check dev->dma_mask,
although only really for sanity checking.

Btw, can I get a review and testing for the above?  They aren't really
experimental any more, and I'd like to move architectures over as soon
as possible.