linux-kernel - Re: [PATCH 8/8] signal: simplify rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180529102456.GA28700@mailbox.org>
Date:   Tue, 29 May 2018 12:24:56 +0200
From:   Christian Brauner <christian@...uner.io>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-kernel@...r.kernel.org, ebiederm@...ssion.com,
        gregkh@...uxfoundation.org, mingo@...nel.org,
        james.morris@...rosoft.com, keescook@...omium.org,
        peterz@...radead.org, sds@...ho.nsa.gov, viro@...iv.linux.org.uk,
        akpm@...ux-foundation.org, oleg@...hat.com
Subject: Re: [PATCH 8/8] signal: simplify rt_sigaction()

On Mon, May 28, 2018 at 11:47:19PM -0700, Christoph Hellwig wrote:
> > +	if (act)
> >  		if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa)))
> >  			return -EFAULT;
> 
> 	if (act && copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa)))
> 		return -EFAULT;

Yes, I agree and should have been bolder in making that change. But I
already wasn't sure how ok people would be with:

if (act) {} --> if (act)

> 
> >  	ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa : NULL);
> > -
> > -	if (!ret && oact) {
> > +	if (!ret && oact)
> >  		if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
> >  			return -EFAULT;
> > -	}
> 
> 	ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa : NULL);
> 	if (!ret && oact && copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
> 		return -EFAULT;
> 
> Althought I'd personaly write it as:
> 
> 	ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa : NULL);
> 	if (ret)
> 		return ret;
> 	if (oact && copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
> 		return -EFAULT;
> 	return 0;

Yeah, I can put that in v2.
I'd wait for a little until people have commmented/acked some of the
other changes so that I don't keep spamming inboxes. If you have a few
spare minutes it would be cool if you could take a quick look. It
shouldn't take long.

Thanks!
Christian