linux-kernel - Re: [PATCH] atm: zatm: fix memcmp casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180529.100019.342627848221840486.davem@davemloft.net>
Date:   Tue, 29 May 2018 10:00:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     brnkv.i1@...il.com
Cc:     3chas3@...il.com, linux-atm-general@...ts.sourceforge.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: zatm: fix memcmp casting

From: Ivan Bornyakov <brnkv.i1@...il.com>
Date: Fri, 25 May 2018 20:49:52 +0300

> memcmp() returns int, but eprom_try_esi() cast it to unsigned char. One
> can lose significant bits and get 0 from non-0 value returned by the
> memcmp().
> 
> Signed-off-by: Ivan Bornyakov <brnkv.i1@...il.com>

Applied, thanks.