linux-kernel - Re: [PATCH] soc: imx: gpcv2: correct PGC offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e0690c89b24b4b028e4a0dab63334af4b37fdd3.camel@nxp.com>
Date:   Tue, 29 May 2018 17:02:31 +0300
From:   Leonard Crestez <leonard.crestez@....com>
To:     Anson Huang <Anson.Huang@....com>, shawnguo@...nel.org,
        Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     Linux-imx@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, fabio.estevam@....com,
        Abel Vesa <abel.vesa@....com>,
        Richard Liu <xuegang.liu@....com>
Subject: Re: [PATCH] soc: imx: gpcv2: correct PGC offset

On Tue, 2018-05-29 at 16:02 +0800, Anson Huang wrote:
> Correct MIPI/PCIe/USB_HSIC's PGC offset based on
> design RTL, the value on Reference Manual are incorrect.
> 
> The correct offset should be as below: 
>  
> -#define PGC_MIPI			4
> -#define PGC_PCIE			5
> -#define PGC_USB_HSIC			8
> +#define PGC_MIPI			16
> +#define PGC_PCIE			17
> +#define PGC_USB_HSIC			20
>  #define GPC_PGC_CTRL(n)			(0x800 + (n) * 0x40)
>  #define GPC_PGC_SR(n)			(GPC_PGC_CTRL(n) + 0xc)

This gpcv2 driver is currently only used for PCI, it probably only
works because domains happen to be turned on by default?

On imx7d upstream platform suspend is not yet supported but even doing
device-level suspend causes a hang on resume somewhere in PCI on first
read. This patch fixes that immediate hang.

After suspend/resume lspci is broken (device doesn't properly resume),
that probably requires more imx pci patches and unrelated to pgc.

--
Regards,
Leonard