linux-kernel - Re: [PATCH -next] misc: ibmvmc: Use GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <995601ab-6fa5-4a72-fd49-337976755861@linux.ibm.com>
Date:   Tue, 29 May 2018 09:15:39 -0500
From:   "Bryant G. Ly" <bryantly@...ux.ibm.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>,
        Steven Royer <seroyer@...ux.vnet.ibm.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] misc: ibmvmc: Use GFP_ATOMIC under spin lock



On 5/26/18 4:45 AM, Wei Yongjun wrote:

> The function alloc_dma_buffer() is called from ibmvmc_add_buffer(),
> in which a spin lock be held here, so we should use GFP_ATOMIC when
> a lock is held.
>
> Fixes: 0eca353e7ae7 ("misc: IBM Virtual Management Channel Driver (VMC)")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/misc/ibmvmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c
> index fb83d13..8f82bb9 100644
> --- a/drivers/misc/ibmvmc.c
> +++ b/drivers/misc/ibmvmc.c
> @@ -273,7 +273,7 @@ static void *alloc_dma_buffer(struct vio_dev *vdev, size_t size,
>  			      dma_addr_t *dma_handle)
>  {
>  	/* allocate memory */
> -	void *buffer = kzalloc(size, GFP_KERNEL);
> +	void *buffer = kzalloc(size, GFP_ATOMIC);
>
>  	if (!buffer) {
>  		*dma_handle = 0;
>
Reviewed-by: Bryant G. Ly <bryantly@...ux.vnet.ibm.com>