linux-kernel - Re: [PATCH v1 05/20] signal: flatten do_send_sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r2lsga0w.fsf@xmission.com>
Date:   Wed, 30 May 2018 15:31:59 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Christian Brauner <christian@...uner.io>
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        mingo@...nel.org, james.morris@...rosoft.com,
        keescook@...omium.org, peterz@...radead.org, sds@...ho.nsa.gov,
        viro@...iv.linux.org.uk, akpm@...ux-foundation.org, oleg@...hat.com
Subject: Re: [PATCH v1 05/20] signal: flatten do_send_sig_info()

Christian Brauner <christian@...uner.io> writes:

2> On Tue, May 29, 2018 at 07:28:27AM -0500, Eric W. Biederman wrote:
>> Christian Brauner <christian@...uner.io> writes:
>> 
>> > Let's return early when lock_task_sighand() fails and move send_signal()
>> > and unlock_task_sighand() out of the if block.
>> 
>> Introducing multiple exits into a function.  Ick.
>> You do know that is what Dijkstra was arguing against in his paper
>> "Goto Considered Harmful"
>> 
>> That introduces mutiple exits and makes the function harder to analyze.
>> It is especially a pain as I have something in my queue that will
>> shuffle things around and remove the possibility of lock_task_sighand
>> failing.
>
> I'm happy to drop this one if you have a fix for this in your tree
> anyway.
>
> Aside from that, I think it might make sense to route this patch series
> through your tree though since you're doing the siginfo rework
> currently.(?)

If you will purely code style changes such as this one I will be happy
to pick up the rest as they are pretty much obviously correct changes.

Eric