linux-kernel - Re: [PATCH] btrfs: raid56: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5j+ZuPAfiTHTZ2KuHn76SxaBBqOnFCiK8q0umHcMT3EPyw@mail.gmail.com>
Date:   Wed, 30 May 2018 13:49:53 -0700
From:   Kees Cook <keescook@...omium.org>
To:     dsterba@...e.cz, Kees Cook <keescook@...omium.org>,
        David Sterba <dsterba@...e.com>, Liu Bo <bo.li.liu@...cle.com>,
        Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        Linux Btrfs <linux-btrfs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] btrfs: raid56: Remove VLA usage

On Wed, May 30, 2018 at 9:08 AM, David Sterba <dsterba@...e.cz> wrote:
> On Wed, May 30, 2018 at 05:14:56PM +0200, David Sterba wrote:
>> On Tue, May 29, 2018 at 04:44:59PM -0700, Kees Cook wrote:
>> > In the quest to remove all stack VLA usage from the kernel[1], this
>> > allocates the working buffers during regular init, instead of using stack
>> > space. This refactors the allocation code a bit to make it easier
>> > to review.
>> >
>> > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>
> For the record, so this was the last use of VLA in fs/btrfs/ .

Correct. And fs/ntfs/ has the last remaining VLAs in fs/.

-Kees

-- 
Kees Cook
Pixel Security