linux-kernel - Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 May 2018 23:27:50 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Alexander Shiyan <shc_work@...l.ru>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Tony Lindgren <tony@...mide.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Philipp Zabel <philipp.zabel@...il.com>,
        Daniel Mack <zonque@...il.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: [PATCH 01/19 v3] regulator: fixed: Convert to use GPIO descriptor only

On Mon, May 14, 2018 at 10:06 AM, Linus Walleij
<linus.walleij@...aro.org> wrote:


> @@ -892,6 +902,7 @@ static void __init e680_init(void)
>
>         pxa_set_keypad_info(&e680_keypad_platform_data);
>
> +       gpiod_add_lookup_table(&camera_supply_gpiod_table);
>         pwm_add_table(ezx_pwm_lookup, ARRAY_SIZE(ezx_pwm_lookup));
>         platform_add_devices(ARRAY_AND_SIZE(ezx_devices));
>         platform_add_devices(ARRAY_AND_SIZE(e680_devices));
> @@ -1098,7 +1109,7 @@ static struct i2c_board_info __initdata a910_i2c_board_info[] = {
>
>  static struct platform_device *a910_devices[] __initdata = {
>         &a910_gpio_keys,
> -       &camera_supply_dummy_device,
> +       &camera_supply_regulator_device,
>  };
>

This part is wrong and triggered a build warning: camera_supply_gpiod_table
should have been in a910_init(), not e680_init(). I sent a fixup with subject
"ARM: pxa, regulator: fix building ezx e680".

        Arnd