linux-kernel - Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=XrhG0N33YF8Uo16Lpq904TEGz8=S7Eb=P=sX52dTtVuA@mail.gmail.com>
Date:   Wed, 30 May 2018 14:48:51 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Raju P L S S S N <rplsssn@...eaurora.org>
Cc:     Lina Iyer <ilina@...eaurora.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        msivasub@...eaurora.org, mkshah@...eaurora.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

Hi,

On Wed, May 23, 2018 at 6:27 AM, Raju P L S S S N
<rplsssn@...eaurora.org> wrote:
>>> +                       break;
>>
>>
>> "break" seems wrong here.  You'll end up waiting for the completion,
>> then I guess timing out, then returning -ETIMEDOUT?
>
>
> As the loop above break runs for remaining count, completion will be
> notified so there will not be waiting.

Ah, I see.  I missed that.

...oh, I guess you need to wait because any requests you might have
made will try to signal your completion which is on the stack...