linux-kernel - Re: [GIT PULL] two more s390 bug fixes for 4.17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180530074130.GA6927@infradead.org>
Date:   Wed, 30 May 2018 00:41:30 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-s390 <linux-s390@...r.kernel.org>,
        Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: [GIT PULL] two more s390 bug fixes for 4.17

> -	req->completion_data = cqr;
> +	*((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr;
> +

Please don't play such tricks.  In general your driver structure
should have struct request embedded.  If for some reason
struct dasd_ccw_req has a different life time please create a new
structure instead of these hacks.

In either way this really doesn't look like a post-rc7 change.