linux-kernel - Re: [PATCH] nvme: prefer strlcpy to strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH7mPvgC7WE-JFUk3aV4_Cex9vm9PO9wRa7gM8-=YdUp5uOv4Q@mail.gmail.com>
Date:   Tue, 29 May 2018 19:02:29 -0700
From:   Nick Desaulniers <nick.desaulniers@...il.com>
To:     Christoph Hellwig <hch@....de>
Cc:     keith.busch@...el.com, axboe@...com, sagi@...mberg.me,
        linux-nvme@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ebiggers@...gle.com
Subject: Re: [PATCH] nvme: prefer strlcpy to strncpy

On Tue, May 29, 2018 at 1:11 AM, Christoph Hellwig <hch@....de> wrote:
> On Mon, May 28, 2018 at 11:49:18PM -0700, Nick Desaulniers wrote:
>> Fixes a stringop-truncation warning from gcc-8.
>
> What would that warning be?  Maybe it actually is genuinly useful,
> and switching to strlcpy just papers over it..

Eric also pointed out to me that strlcpy will not initialize the rest
of dest with zeros if size is less than the length of src.