linux-kernel - Re: [PATCH] lib/plist.c: Export plist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a59865a-1143-3ba1-8be7-cf590d422c36@codeaurora.org>
Date:   Wed, 30 May 2018 17:55:05 +0530
From:   Hareesh Gundu <hareeshg@...eaurora.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Steven Rostedt <rostedt@...dmis.org>, jcrouse@...eaurora.org,
        Mel Gorman <mgorman@...e.de>, efault@....de,
        tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/plist.c: Export plist_*() APIs



On 12/6/2017 9:29 PM, Peter Zijlstra wrote:
> On Wed, Dec 06, 2017 at 08:59:27PM +0530, Hareesh Gundu wrote:
>> On 12/5/2017 8:11 PM, Peter Zijlstra wrote:
>>> On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote:
>>>> Allow plist_add(), plist_del() and plist_requeue() APIs to
>>>> be referenced by kernel modules by adding the EXPORT_SYMBOL().
>> This change is not for in-tree kernel module. It's for modules built outside
>> of kernel tree modules.
>>
>> Is it really required to show out tree kernel modules ?
> Typically we don't add EXPORTs for functions not used in in-tree
> modules.
We changed our design and planned to have our module in-tree kernel 
instead of out tree kernel module.
Below is the reference for in-tree kernel module proposal for 
"drviers/gpu/msm" which is referring to plist_* symbols.

https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/msm/adreno_dispatch.c?h=msm-4.9#n533

Could you please revisit the patch and approve for upstream.