linux-kernel - [PATCH] usb: dwc2: gadget: fix missing process for isoc descriptor dma mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1527681676-44003-1-git-send-email-prime.zeng@hisilicon.com>
Date:   Wed, 30 May 2018 20:01:15 +0800
From:   Zeng Tao <prime.zeng@...ilicon.com>
To:     <hminas@...opsys.com>
CC:     Zeng Tao <prime.zeng@...ilicon.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] usb: dwc2: gadget: fix missing process for isoc descriptor dma mode

If it's the first request to queue, and we are using descriptor dma mode
for isoc transfer, we only need to add the request to the queue, and it
will be processed in the future nak interrupt handler.

Signed-off-by: Zeng Tao <prime.zeng@...ilicon.com>
---
 drivers/usb/dwc2/gadget.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index f0d9ccf..48e3a48c 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -1365,6 +1365,9 @@ static int dwc2_hsotg_ep_queue(struct usb_ep *ep, struct usb_request *req,
 			return 0;
 		}
 
+		if (using_desc_dma(hs))
+			return 0;
+
 		/* Update current frame number value. */
 		hs->frame_number = dwc2_hsotg_read_frameno(hs);
 		while (dwc2_gadget_target_frame_elapsed(hs_ep)) {
-- 
2.7.4