linux-kernel - Re: [PATCH] btrfs: raid56: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180530151455.GE3539@twin.jikos.cz>
Date:   Wed, 30 May 2018 17:14:56 +0200
From:   David Sterba <dsterba@...e.cz>
To:     Kees Cook <keescook@...omium.org>
Cc:     David Sterba <dsterba@...e.com>, Liu Bo <bo.li.liu@...cle.com>,
        Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: raid56: Remove VLA usage

On Tue, May 29, 2018 at 04:44:59PM -0700, Kees Cook wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> allocates the working buffers during regular init, instead of using stack
> space. This refactors the allocation code a bit to make it easier
> to review.
> 
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

Reviewed-by: David Sterba <dsterba@...e.com>

Queued for 4.18, thanks.