linux-kernel - Re: [PATCHv2 0/2] Add new SEV commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180531064534.ldi2ysuhh2omex5d@gondor.apana.org.au>
Date:   Thu, 31 May 2018 14:45:34 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Gary R Hook <gary.hook@....com>
Cc:     Janakarajan Natarajan <Janakarajan.Natarajan@....com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Lendacky <thomas.lendacky@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Brijesh Singh <brijesh.singh@....com>,
        Borislav Petkov <bp@...e.de>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCHv2 0/2] Add new SEV commands

On Wed, May 30, 2018 at 01:44:12PM -0500, Gary R Hook wrote:
> On 05/30/2018 11:28 AM, Herbert Xu wrote:
> > On Fri, May 25, 2018 at 03:23:28PM -0500, Janakarajan Natarajan wrote:
> > > This patchset adds two new SEV commands, introduced in SEV API v0.15
> > > and v0.16 respectively.
> > > 
> > > * DOWNLOAD_FIRMWARE allows the SEV firmware to be updated if a blob newer
> > >    than or similar to the exisiting build is available.
> > > 
> > > * GET_ID allows to query for a unique ID that can be used to retrieve the
> > >    Chip Endorsment Key (CEK) public key signed by the AMD SEV Signing Key
> > >    (ASK).
> > > 
> > > v1->v2:
> > > * Added cover letter.
> > > * Misc changes based on Boris' feedback.
> > > 
> > > Janakarajan Natarajan (2):
> > >    crypto: ccp: Add DOWNLOAD_FIRMWARE SEV command
> > >    crypto: ccp: Add GET_ID SEV command
> > > 
> > >   drivers/crypto/ccp/psp-dev.c | 143 ++++++++++++++++++++++++++++++++++++++++---
> > >   drivers/crypto/ccp/psp-dev.h |   4 ++
> > >   include/linux/psp-sev.h      |  23 +++++++
> > >   include/uapi/linux/psp-sev.h |  12 ++++
> > >   4 files changed, 172 insertions(+), 10 deletions(-)
> > 
> > All applied.  Thanks.
> 
> Huh. Without a Reviewed-by or an Acked-by?

These patches have been out there for weeks.  If you were going
to object you should have done so by now.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt