linux-kernel - Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180531070518.obnfw5tv23sbpfys@mwanda>
Date:   Thu, 31 May 2018 10:05:18 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Colin King <colin.king@...onical.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev =
 dev

On Wed, May 30, 2018 at 05:07:15PM -0400, Alexei Starovoitov wrote:
> On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The assignment dev = dev is redundant and should be removed.
> > 
> > Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
> > 
> > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Applied, Thanks.
> 
> Please use [PATCH bpf-next] in the subject next time.
> See Documentation/bpf/bpf_devel_QA.rst

Guys, be reasonable...

git log --author=Carpenter | \
	grep -A1 "Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>" | \
	grep -v Carpenter | grep Signed | cut -d '<' -f 1 | sort -u | wc -l

I have sent patches to 206 maintainers.  It doesn't scale for everyone
to have their own special document for sending patches.

I asked this last time, and I even skimmed your document, but how are
people supposed to go from linux-next to the correct bpf-next git tree?
It's a pain for me to do this for net, but net is way larger and busier
than any other tree.  I know it's a bit rude for me to say that you guys
are not as important as net, but that's how I feel.  I'm only going to
report bugs instead of writing patches if you guys are going to insist
on all sorts of new rules.

regards,
dan carpenter