linux-kernel - Re: [PATCH] ALSA: unhide snd_soc_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <583985db-c99c-9b22-ab00-186d5d5cfa67@sakamocchi.jp>
Date:   Thu, 31 May 2018 10:12:19 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Arnd Bergmann <arnd@...db.de>, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     alsa-devel@...a-project.org,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        linux-kernel@...r.kernel.org,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH] ALSA: unhide snd_soc_new_compress() declaration

Hi,

On May 31 2018 07:06, Arnd Bergmann wrote:
> My randconfig build setup came across a new build failure today:
> 
> sound/soc/soc-topology.c: In function 'soc_tplg_dai_create':
> sound/soc/soc-topology.c:1758:27: error: 'snd_soc_new_compress' undeclared (first use in this function); did you mean 'snd_soc_compr_ops'?
>     dai_drv->compress_new = snd_soc_new_compress;
> 
> Simply making that prototype visible again fixes the build failure
> for me, though I'm not exactly sure why we don't get a link
> error now.
> 
> The reference to snd_soc_new_compress() was added a few weeks
> ago and seems to have caused the problem.
> 
> Fixes: 5db6aab6f36f ("ASoC: topology: Add support for compressed PCMs")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   include/sound/soc.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/sound/soc.h b/include/sound/soc.h
> index 600a7ebd10c0..8e073865bde3 100644
> --- a/include/sound/soc.h
> +++ b/include/sound/soc.h
> @@ -460,9 +460,7 @@ struct snd_soc_component *snd_soc_lookup_component(struct device *dev,
>   						   const char *driver_name);
>   
>   int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num);
> -#ifdef CONFIG_SND_SOC_COMPRESS
>   int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num);
> -#endif
>   
>   void snd_soc_disconnect_sync(struct device *dev);

This bug was fixed by a commit 0b014d72ebae ('ASoC: fix 0-day warnings
with snd_soc_new_compress()')[1][2] in Mark's tree. It applies an 
different solution to add an alternative inline function.

A small nitpicking; please add 'ASoC' prefix when posting patches to
ALSA SoC part, instead of 'ALSA'.

[1] [alsa-devel] [PATCH] ASoC: fix 0-day warnings with 
snd_soc_new_compress()
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-May/136620.html
[2] ASoC: fix 0-day warnings with snd_soc_new_compress()
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-4.18&id=0b014d72ebae14c0c6ab3fb36a442fda91e1a1b3


Thanks

Takashi Sakamoto