linux-kernel - Re: [PATCH v2] ARM: dts: imx51-zii-rdu1: Make sure SD1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 May 2018 12:12:59 +0300
From:   Nikita Yushchenko <nikita.yoush@...entembedded.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>,
        Shawn Guo <shawnguo@...nel.org>
Cc:     Fabio Estevam <fabio.estevam@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Chris Healy <cphealy@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: dts: imx51-zii-rdu1: Make sure SD1_WP is low

> Make sure that MX51_PAD_GPIO1_1 does not remain configure as
> ALT0/SD1_WP (it is out of reset). This is needed because of external
> pull-up resistor attached to that pad that, when left unchanged, will
> drive SD1_WP high preventing eSDHC1/eMMC from working correctly.
> 
> To fix that add a pinmux configuration line configureing the pad to
> function as a GPIO. While we are at it, add a corresponding
> output-high GPIO hog in an effort to minimize current consumption.
> 
> Cc: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Cc: Fabio Estevam <fabio.estevam@....com>
> Cc: Lucas Stach <l.stach@...gutronix.de>
> Cc: Chris Healy <cphealy@...il.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: devicetree@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>

Tested-By: Nikita Yushchenko <nikita.yoush@...entembedded.com

Tested on 8.9'' RDU1. Without this patch, eMMC does not work, get

[   40.801367] mmc0: Timeout waiting for hardware interrupt.
[   40.806789] mmc0: sdhci: ============ SDHCI REGISTER DUMP ===========
... <dump follows>

With this patch, eMMC works correctly.

Nikita